Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Session. #2615

Merged
merged 12 commits into from
Apr 8, 2024
Merged

refactor: Session. #2615

merged 12 commits into from
Apr 8, 2024

Conversation

prmukherj
Copy link
Collaborator

No description provided.

@mkundu1
Copy link
Contributor

mkundu1 commented Mar 26, 2024

Please add tests for the new warnings.

@prmukherj
Copy link
Collaborator Author

Please add tests for the new warnings.

Will do, actually other refactoring for session level will also be done with this.

@prmukherj prmukherj linked an issue Apr 1, 2024 that may be closed by this pull request
Session interface further restructuring #2605
Closed
@prmukherj prmukherj marked this pull request as ready for review April 3, 2024 04:27
@prmukherj
Copy link
Collaborator Author

Please add tests for the new warnings.

Will do, actually other refactoring for session level will also be done with this.

@mkundu1, No new warnings have been added as part of this PR. We have decided to directly make these changes without adding deprecation warnings.

mkundu1
mkundu1 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mkundu1 mkundu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please verify PyConsole with this restructuring? These changes will be packaged in Fluent's PyFluent sometime during 25.1 development but we can verify them before merging this PR. You can set FLUENT_PYFLUENT_ROOT env var to pickup your local PyFluent in PyConsole.

@prmukherj
Copy link
Collaborator Author

Can you please verify PyConsole with this restructuring? These changes will be packaged in Fluent's PyFluent sometime during 25.1 development but we can verify them before merging this PR. You can set FLUENT_PYFLUENT_ROOT env var to pickup your local PyFluent in PyConsole.

Few minor issues needs fixing for 25.1. I have them locally and checked it's working as well. I'll push them as soon as the develop branch for 25.1 is available.

@prmukherj prmukherj merged commit 4d8bd31 into main Apr 8, 2024
26 checks passed
@prmukherj prmukherj deleted the maint/session_refactoring branch April 8, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkundu1 mkundu1 mkundu1 approved these changes

@ajain-work ajain-work ajain-work approved these changes

@hpohekar hpohekar hpohekar approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

@raph-luc raph-luc Awaiting requested review from raph-luc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session interface further restructuring
4 participants
@prmukherj @mkundu1 @ajain-work @hpohekar