Pathlines and changes for request info #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-work
commented
Oct 3, 2022
ajain-work
force-pushed
the
feat/pathlines
branch
2 times, most recently
from
9391868 to
cb2cab7
Compare
ajain-work
commented
Oct 4, 2022
ajain-work
requested review from
mkundu1,
hpohekar,
prmukherj and
seanpearsonuk
prmukherj
approved these changes
Oct 4, 2022
hpohekar
approved these changes
Oct 4, 2022
seanpearsonuk
approved these changes
Oct 4, 2022
ajain-work
force-pushed
the
feat/pathlines
branch
from
4e4bcc1 to
876d41e
Compare
ajain-work
force-pushed
the
feat/pathlines
branch
from
93d3171 to
ad2c608
Compare
mkundu1
approved these changes
Nov 4, 2022
ajain-work
force-pushed
the
feat/pathlines
branch
from
cf1263a to
7896dba
Compare
ajain-work
force-pushed
the
feat/pathlines
branch
from
0472c98 to
6e2c2e8
Compare
ajain-work
force-pushed
the
feat/pathlines
branch
from
3ade7e0 to
6392b14
Compare
ajain-work
commented
Nov 7, 2022
| pathlines = graphics.Pathlines["pathlines"] | ||
| pathlines.field = "velocity-magnitude" | ||
| pathlines.surfaces_list = ["inlet", "inlet1", "inlet2"] | ||
| # pathlines.display("window-9") |
There was a problem hiding this comment.
@akulshre-qa @ypatel-qa Now pathlines is also supported. Currently commented.
|
Testing can resume pending the fix for Issue #153 and further discussion of which attributes should be supported for release of pathlines support (ie - path skip, step size, show_edges, etc). In addition to exposing the example, we will plan to have at least one integration test involving a vof model with pathlines per the discussion with @ajain-work. Please let us know if there is any concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains following changes: