Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean init file #519

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Clean init file #519

merged 2 commits into from
Oct 20, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Oct 19, 2023

Remove call to core.settings.set_dynamic_available_results_capability(False)

@cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

@FedericoNegri reported it being there and not necessarily being practical for the user in some situations.

@PProfizi PProfizi added the maintenance Repository structure maintenance label Oct 19, 2023
@PProfizi PProfizi self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #519 (49c8be4) into master (bb37a46) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   83.83%   83.78%   -0.06%     
==========================================
  Files          47       47              
  Lines        5072     5068       -4     
==========================================
- Hits         4252     4246       -6     
- Misses        820      822       +2     

@cbellot000
Copy link
Contributor

Remove call to core.settings.set_dynamic_available_results_capability(False)

@cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

It's an API from pydpf-core? It would have been with the legacy API. But I'm intesrested to see where it's used in core?

@PProfizi
Copy link
Contributor Author

Remove call to core.settings.set_dynamic_available_results_capability(False)
@cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

It's an API from pydpf-core? It would have been with the legacy API. But I'm intesrested to see where it's used in core?

It is in ansys.dpf.core.settings, and it switches the variable misc.DYNAMIC_RESULTS which is used in Model.results here to force having only CommonResults.

It was dedicated to the legacy PyDPF-Post, but since it is in the init, it is the case also for the new Post API.

@PProfizi PProfizi merged commit b61bffa into master Oct 20, 2023
23 checks passed
@PProfizi PProfizi deleted the feat/clean_init branch October 20, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repository structure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants