Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement request of fluid results using faces #462

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

PProfizi
Copy link
Contributor

Available with server 2024.1.pre1

@PProfizi PProfizi added the enhancement New feature or request label Aug 11, 2023
@PProfizi PProfizi added this to the v0.5.1 milestone Aug 11, 2023
@PProfizi PProfizi self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #462 (05325bd) into master (48b9464) will increase coverage by 8.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   75.15%   83.51%   +8.35%     
==========================================
  Files          45       45              
  Lines        4967     4973       +6     
==========================================
+ Hits         3733     4153     +420     
+ Misses       1234      820     -414     

@PProfizi PProfizi requested review from cbellot000 and anslpa August 11, 2023 15:49
@PProfizi PProfizi merged commit 87cf0ef into master Aug 11, 2023
@PProfizi PProfizi deleted the fix/requests_on_faces branch August 11, 2023 16:07
@PProfizi PProfizi requested a review from rafacanton August 11, 2023 17:20
assert result.index.mesh_index.location == post.locations.faces
# assert (
# len(result.index.mesh_index.values) == len(fluent_simulation.mesh.face_ids)
# ) # TODO: why does this fail? Is the result not defined everywhere?
Copy link
Contributor

@rafacanton rafacanton Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi Because we are not reading the results for interior faces. I have checked for the first cas file in the axial_comp model and I can confirm that:

  • The overall mesh has 44242 faces.
  • There are two interior zones that account for 38894 faces.
  • The static_pressure result on faces has 5348 entities, which is exactly the same as 44242 - 38894.

This is consistent with the fact that the interior zones are not even included as available Ids in the qualifiers of the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants