Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retro-compatibility with 222 and 221 #339

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Fix retro-compatibility with 222 and 221 #339

merged 8 commits into from
Mar 20, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Mar 20, 2023

The ANSYS_VERSION input in retro tests in ci.yml and ci_release.yml was set to env.ANSYS_VERSION instead of matrix.ANSYS_VERSION, meaning retro tests actually ran on the latest server.

Once this is rectified, it appears that operator extract_scoping is too recent to be used.
It is in the code at:

  • scoping workflow associated to a DataFrame, instantiated in _get_result for each Simulation variant -> Actually unused, remove useless code in HarmonicMechanicalSimulation, ModalMechanicalSimulation and TransientMechanicalSimulation
  • in MeshIndex._evaluate_values in case self._scoping_ref is None -> implement a retro-compatible (slower) version when DPF<5.0

@PProfizi PProfizi added the bug Something isn't working label Mar 20, 2023
@PProfizi PProfizi self-assigned this Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #339 (9e1ca0d) into master (5c5d79a) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 9e1ca0d differs from pull request most recent head c1d2104. Consider uploading reports for the commit c1d2104 to get more accurate results

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   82.72%   82.66%   -0.06%     
==========================================
  Files          35       35              
  Lines        3184     3173      -11     
==========================================
- Hits         2634     2623      -11     
  Misses        550      550              

@PProfizi PProfizi requested a review from cbellot000 March 20, 2023 14:52
@PProfizi PProfizi changed the title Fix retro-compatibility testing Fix retro-compatibility with 222 and 221 Mar 20, 2023
@PProfizi PProfizi requested a review from anslpa March 20, 2023 14:54
@PProfizi PProfizi merged commit fb17938 into master Mar 20, 2023
@PProfizi PProfizi deleted the bug/fix_retro branch March 20, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants