Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to pyproject.toml - contact email #328

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Mar 10, 2023

At the https://github.com/pyansys/pyansys-dev package we are experiencing some issues with a recent modification to your pyproject.toml file...

We have the feeling that it may be caused by the fact that you may be calling the entire repository as a dependency, while we are targeting a specific branch (master). In any case, if you want to leave it as it was, it would also be fine. It'd be more accurrate to just target the master branch on your side for this use case.

@RobPasMue RobPasMue self-assigned this Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #328 (7c8e4a4) into master (0aaf55f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files          35       35           
  Lines        3170     3170           
=======================================
  Hits         2621     2621           
  Misses        549      549           

@RobPasMue
Copy link
Member Author

Nah, probably not needed... Let me revert them. But the contact email should be changed in any case :)

@RobPasMue RobPasMue changed the title Improvements to pyproject.toml Improvements to pyproject.toml - contact email Mar 10, 2023
@PProfizi
Copy link
Contributor

Nah, probably not needed... Let me revert them. But the contact email should be changed in any case :)

Thank you for the changes!
This direct dependency to the git repo for ansys-dpf-core dates back to the addition of the pyproject.toml. I think it clones the repo and checks-out master, but since master is default, I do not think it downloads more than needed.

@PProfizi PProfizi added the CI/CD label Mar 10, 2023
@RobPasMue RobPasMue merged commit ff74490 into master Mar 10, 2023
@RobPasMue RobPasMue deleted the fix/pyansys-dev branch March 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants