Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to select and plot when no data is returned #312

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Mar 6, 2023

No description provided.

@PProfizi PProfizi added the bug Something isn't working label Mar 6, 2023
@PProfizi PProfizi added this to the v0.2.6 milestone Mar 6, 2023
@PProfizi PProfizi requested a review from cbellot000 March 6, 2023 15:00
@PProfizi PProfizi self-assigned this Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #312 (0ba8908) into post_refactor (c1a80cf) will increase coverage by 0.05%.
The diff coverage is 85.71%.

@@                Coverage Diff                @@
##           post_refactor     #312      +/-   ##
=================================================
+ Coverage          82.64%   82.69%   +0.05%     
=================================================
  Files                 35       35              
  Lines               3146     3167      +21     
=================================================
+ Hits                2600     2619      +19     
- Misses               546      548       +2     

@PProfizi PProfizi merged commit 21cd118 into post_refactor Mar 6, 2023
@PProfizi PProfizi deleted the post_refactor_fixes_select_and_plot branch March 6, 2023 16:29
PProfizi added a commit that referenced this pull request Mar 8, 2023
* Treat case of empty list for values in Index

* Raise a warning if selection in DataFrame.plot resulted in no data to plot. Also warn if selection resulted in incompatible data to plot. Also treat merge multiple elshape if no selection was explicitly made.

* Fix selection when label selection results in no fields to extract.

* Add test_dataframe_plot_warn
PProfizi added a commit that referenced this pull request Mar 8, 2023
* Treat case of empty list for values in Index

* Raise a warning if selection in DataFrame.plot resulted in no data to plot. Also warn if selection resulted in incompatible data to plot. Also treat merge multiple elshape if no selection was explicitly made.

* Fix selection when label selection results in no fields to extract.

* Add test_dataframe_plot_warn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant