-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iselect, update DataFrame.axes, Naming convention #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PProfizi
commented
Mar 3, 2023
•
edited
Loading
edited
- DataFrame.axes now returns [DataFrame.index, DataFrame.columns], the two MultiIndex objects, like in Pandas.
- Fix bug for iselect when selecting on a label with a list of indices.
- Make naming coherent between result query API arguments and DataFrame indexes default names. Increase default width of columns for printed DataFrame.
- Fix examples
- Fix transferring kwargs to plot (cannot raise 'unknown axis' anymore)
- Fix multi-label selection
…pdate 04-harmonic-complex-results.py
Codecov Report
@@ Coverage Diff @@
## post_refactor #304 +/- ##
=================================================
+ Coverage 82.36% 82.63% +0.26%
=================================================
Files 35 35
Lines 3079 3098 +19
=================================================
+ Hits 2536 2560 +24
+ Misses 543 538 -5 |
cbellot000
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great, thanks!
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Add test for DataFrame.animate. Not ready yet. * DataFrame.axes returns [df.index, df.columns] just like in Pandas. * Make naming coherent between result queries and Index names * Fix iselect with list of indices on label * Fix test_simulation/test_elemental_ns_on_nodal_result * Update 01-static-simulation.py and 02-modal-simulation.py with new axis naming. * Fix and update 03-transient-simulation.py * Fix multi-label selection (do not raise 'unknown axis' anymore) and update 04-harmonic-complex-results.py
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Add test for DataFrame.animate. Not ready yet. * DataFrame.axes returns [df.index, df.columns] just like in Pandas. * Make naming coherent between result queries and Index names * Fix iselect with list of indices on label * Fix test_simulation/test_elemental_ns_on_nodal_result * Update 01-static-simulation.py and 02-modal-simulation.py with new axis naming. * Fix and update 03-transient-simulation.py * Fix multi-label selection (do not raise 'unknown axis' anymore) and update 04-harmonic-complex-results.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.