Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iselect, update DataFrame.axes, Naming convention #304

Merged
merged 8 commits into from
Mar 3, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Mar 3, 2023

  • DataFrame.axes now returns [DataFrame.index, DataFrame.columns], the two MultiIndex objects, like in Pandas.
  • Fix bug for iselect when selecting on a label with a list of indices.
  • Make naming coherent between result query API arguments and DataFrame indexes default names. Increase default width of columns for printed DataFrame.
  • Fix examples
  • Fix transferring kwargs to plot (cannot raise 'unknown axis' anymore)
  • Fix multi-label selection

@PProfizi PProfizi added this to the v0.2.6 milestone Mar 3, 2023
@PProfizi PProfizi self-assigned this Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #304 (2b2d90d) into post_refactor (9875d43) will increase coverage by 0.26%.
The diff coverage is 86.76%.

@@                Coverage Diff                @@
##           post_refactor     #304      +/-   ##
=================================================
+ Coverage          82.36%   82.63%   +0.26%     
=================================================
  Files                 35       35              
  Lines               3079     3098      +19     
=================================================
+ Hits                2536     2560      +24     
+ Misses               543      538       -5     

Copy link
Contributor

@cbellot000 cbellot000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great, thanks!

@PProfizi PProfizi merged commit e23f24c into post_refactor Mar 3, 2023
@PProfizi PProfizi deleted the post_refactor_friday_fixes branch March 3, 2023 12:58
PProfizi added a commit that referenced this pull request Mar 8, 2023
* Add test for DataFrame.animate. Not ready yet.

* DataFrame.axes returns [df.index, df.columns] just like in Pandas.

* Make naming coherent between result queries and Index names

* Fix iselect with list of indices on label

* Fix test_simulation/test_elemental_ns_on_nodal_result

* Update 01-static-simulation.py and 02-modal-simulation.py with new axis naming.

* Fix and update 03-transient-simulation.py

* Fix multi-label selection (do not raise 'unknown axis' anymore) and update 04-harmonic-complex-results.py
PProfizi added a commit that referenced this pull request Mar 8, 2023
* Add test for DataFrame.animate. Not ready yet.

* DataFrame.axes returns [df.index, df.columns] just like in Pandas.

* Make naming coherent between result queries and Index names

* Fix iselect with list of indices on label

* Fix test_simulation/test_elemental_ns_on_nodal_result

* Update 01-static-simulation.py and 02-modal-simulation.py with new axis naming.

* Fix and update 03-transient-simulation.py

* Fix multi-label selection (do not raise 'unknown axis' anymore) and update 04-harmonic-complex-results.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants