Implement HarmonicMechanicalSimulation results #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of core.locations
Codecov Report
@@ Coverage Diff @@
## post_refactor #293 +/- ##
=================================================
+ Coverage 80.16% 81.68% +1.52%
=================================================
Files 33 34 +1
Lines 2410 2583 +173
=================================================
+ Hits 1932 2110 +178
+ Misses 478 473 -5 |
…g_pahse and amplitude)
…odal and _elemental
…ration for now due to GitHub CI.
cbellot000
approved these changes
Feb 27, 2023
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Add HarmonicMechanicalSimulation * Add amplitude step to _get_result generated workflow * Add amplitude test * Only use "from ansys.dpf import post" and use post.locations instead of core.locations * Update _get_result with latest changes in Static, Transient and Modal * Add user-friendly and autocomplete friendly inits for simulation types. * Add node_ids argument to non-located result APIs for Static * Add node_ids argument to non-located result APIs for Transient * Add node_ids argument to non-located result APIs for Modal * Fix type hinting for MechanicalSimulation._build_selection * Fix load_simulation with new Simulation init * Raise an error if node_ids is given while location is not nodal * Remove first set as default (copied from modal) * Add a default sweeping_phase operator at 0° * Fix docstring in transient_mechanical_simulation.py * Add result APIs to harmonic_mechanical_simulation.py (without sweeping_pahse and amplitude) * Add tests to harmonic_mechanical_simulation.py * Fix modal_mechanical_simulation.py tests * Fix _get_result docstring * Add coverage for elastic_strain_eqv_von_mises methods * Fix TestModalMechanicalSimulation.test_elastic_strain_eqv_von_mises_nodal and _elemental * Remove TestHarmonicMechanicalSimulation.test_velocity and test_acceleration for now due to GitHub CI. * Test with the latest released ansys-dpf-core and not its current master. * Change references to locations in docstrings to only mention locations.X * Improve load_steps argument docstring.
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* Add HarmonicMechanicalSimulation * Add amplitude step to _get_result generated workflow * Add amplitude test * Only use "from ansys.dpf import post" and use post.locations instead of core.locations * Update _get_result with latest changes in Static, Transient and Modal * Add user-friendly and autocomplete friendly inits for simulation types. * Add node_ids argument to non-located result APIs for Static * Add node_ids argument to non-located result APIs for Transient * Add node_ids argument to non-located result APIs for Modal * Fix type hinting for MechanicalSimulation._build_selection * Fix load_simulation with new Simulation init * Raise an error if node_ids is given while location is not nodal * Remove first set as default (copied from modal) * Add a default sweeping_phase operator at 0° * Fix docstring in transient_mechanical_simulation.py * Add result APIs to harmonic_mechanical_simulation.py (without sweeping_pahse and amplitude) * Add tests to harmonic_mechanical_simulation.py * Fix modal_mechanical_simulation.py tests * Fix _get_result docstring * Add coverage for elastic_strain_eqv_von_mises methods * Fix TestModalMechanicalSimulation.test_elastic_strain_eqv_von_mises_nodal and _elemental * Remove TestHarmonicMechanicalSimulation.test_velocity and test_acceleration for now due to GitHub CI. * Test with the latest released ansys-dpf-core and not its current master. * Change references to locations in docstrings to only mention locations.X * Improve load_steps argument docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement result extraction APIs for HarmonicMechanicalSimulation.
HarmonicMechanicalSimulation methods
(checked: tested, italic: implemented)