Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install commands #281

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Update install commands #281

merged 5 commits into from
Mar 6, 2023

Conversation

PProfizi
Copy link
Contributor

No description provided.

@PProfizi PProfizi added the documentation Improvements or additions to documentation label Feb 10, 2023
@PProfizi PProfizi self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #281 (9e0aa6b) into master (3f89cfe) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e0aa6b differs from pull request most recent head bb9f5e2. Consider uploading reports for the commit bb9f5e2 to get more accurate results

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files          25       25           
  Lines        1351     1351           
=======================================
  Hits         1130     1130           
  Misses        221      221           

@germa89 germa89 requested a review from PipKat March 2, 2023 11:19
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
docs/source/getting_started/install.rst Outdated Show resolved Hide resolved
@germa89
Copy link
Contributor

germa89 commented Mar 2, 2023

Please @PipKat if you can have a super quick look :)

Co-authored-by: German <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
@PProfizi
Copy link
Contributor Author

PProfizi commented Mar 2, 2023

@PipKat @germa89 thank you both so much for your help!

@PProfizi
Copy link
Contributor Author

PProfizi commented Mar 2, 2023

Problem with left-side navigation panels:
image

Is there perhaps a heading level skipped? I did note a strange navigation issue in ansys/pyansys-dev-guide#267, which is now closed.
At the bottom of this dev guide page (https://dev.docs.pyansys.com/dev/doc-style/index.html), there is a link to the "Documenting" page. When it is clicked, the nav pane on the right doesn't show the page title. I assumed it was a font color issue, but maybe something in the latest changes to the Ansys Sphinx template is causing issues? @Revathyvenugopal162

image

@Revathyvenugopal162
Copy link
Contributor

Problem with left-side navigation panels: image

Is there perhaps a heading level skipped? I did note a strange navigation issue in pyansys/dev-guide#267, which is now closed. At the bottom of this dev guide page (https://dev.docs.pyansys.com/dev/doc-style/index.html), there is a link to the "Documenting" page. When it is clicked, the nav pane on the right doesn't show the page title. I assumed it was a font color issue, but maybe something in the latest changes to the Ansys Sphinx template is causing issues? @Revathyvenugopal162

image

@PProfizi the style has been fixed in ansys-sphinx-theme 0.9.5, to fix the sidebar please remove https://github.com/pyansys/pydpf-post/blob/master/docs/source/_templates/sidebar-nav-bs.html doc as i explaned in yesterdays meeting.

@PProfizi
Copy link
Contributor Author

PProfizi commented Mar 6, 2023

Thx @Revathyvenugopal162! This fixed the issue!

@PProfizi PProfizi merged commit c5b81ba into master Mar 6, 2023
@PProfizi PProfizi deleted the doc/update_install branch March 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants