Post refactor - First PR #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## post_refactor #208 +/- ##
=================================================
- Coverage 83.64% 76.89% -6.75%
=================================================
Files 25 30 +5
Lines 1351 1632 +281
=================================================
+ Hits 1130 1255 +125
- Misses 221 377 +156 |
* Add DataObject. * Update src/ansys/dpf/post/data_object.py * Update src/ansys/dpf/post/data_object.py
GuillemBarroso
approved these changes
Dec 19, 2022
Co-authored-by: Guillem Barroso <[email protected]>
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* selection implementation * workflow * Create a Mesh class * Work on the displacement method (state before using Selection as a workflow) * Testing * Rework TimeFreqSelection and SpatialSelection * Overwritting call to dpfmechanical object * Reorg * Add DataObject. (#210) * Add DataObject. * Update src/ansys/dpf/post/data_object.py * Update src/ansys/dpf/post/data_object.py * pre meeting * Add Solution.results property * Create the PandasImportError * Fix circular import due to Type Hinting * fixes for demo * Set the pydpf-core dependency onto a branch instead of the latest released version * Remove ssh from core dependency link * Remove ssh from core dependency link * Use master branch of pydpf-core and do not import core.geometry_factory yet. * Fix List[str] typehinting for Python < 3.9 * Fix Optional typehinting unavailable for Python < 3.9 * Fix Optional typehinting unavailable for Python < 3.9 * Fix segfault at import * Fix pre-commit test_selection.py * Fix pre-commit data_object.py * Fix pre-commit errors.py * Fix pre-commit mesh.py * Fix pre-commit example.py * Fix pre-commit meeting.py * Fix Union * Fix List for 3.8 * Change back to legacy solution before creating the argument * Add pandas to requirements_test.txt * Fix black static_analysis.py * pandas 1.3.5 is the latest with support for Python 3.7 * Add legacy argument to load_solution, apply it where necessary. * Fix test_selection.py * Comment-out tests not yet working. Solve in specific PR * Apply suggestions from code review Co-authored-by: Guillem Barroso <[email protected]> * Revert getting name from __name__ Co-authored-by: cbellot <[email protected]> Co-authored-by: PProfizi <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: PProfizi <[email protected]> Co-authored-by: Guillem Barroso <[email protected]>
PProfizi
added a commit
that referenced
this pull request
Mar 8, 2023
* selection implementation * workflow * Create a Mesh class * Work on the displacement method (state before using Selection as a workflow) * Testing * Rework TimeFreqSelection and SpatialSelection * Overwritting call to dpfmechanical object * Reorg * Add DataObject. (#210) * Add DataObject. * Update src/ansys/dpf/post/data_object.py * Update src/ansys/dpf/post/data_object.py * pre meeting * Add Solution.results property * Create the PandasImportError * Fix circular import due to Type Hinting * fixes for demo * Set the pydpf-core dependency onto a branch instead of the latest released version * Remove ssh from core dependency link * Remove ssh from core dependency link * Use master branch of pydpf-core and do not import core.geometry_factory yet. * Fix List[str] typehinting for Python < 3.9 * Fix Optional typehinting unavailable for Python < 3.9 * Fix Optional typehinting unavailable for Python < 3.9 * Fix segfault at import * Fix pre-commit test_selection.py * Fix pre-commit data_object.py * Fix pre-commit errors.py * Fix pre-commit mesh.py * Fix pre-commit example.py * Fix pre-commit meeting.py * Fix Union * Fix List for 3.8 * Change back to legacy solution before creating the argument * Add pandas to requirements_test.txt * Fix black static_analysis.py * pandas 1.3.5 is the latest with support for Python 3.7 * Add legacy argument to load_solution, apply it where necessary. * Fix test_selection.py * Comment-out tests not yet working. Solve in specific PR * Apply suggestions from code review Co-authored-by: Guillem Barroso <[email protected]> * Revert getting name from __name__ Co-authored-by: cbellot <[email protected]> Co-authored-by: PProfizi <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: PProfizi <[email protected]> Co-authored-by: Guillem Barroso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Solution with solution.py
Adds Selection, TimeFreqSelection, SpatialSelection with selection.py
Adds DataObject with data_object.py
Adds Mesh with mesh.py
Adds tools.select with tools.py
Adds temporary example and meeting notes in temp/