Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connecting Any as inpt #1991

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix connecting Any as inpt #1991

merged 3 commits into from
Jan 7, 2025

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jan 7, 2025

Error was raised when doing:

from ansys.dpf.core import operators as ops

f1 = ops.utility.forward()
f2 = ops.utility.forward()
f2.inputs.any.connect(f1.outputs.any)

Error marked pin connection as ambiguous due to mismanagement of Any pin type in Operator._find_outputs_corresponding_pins.

The whole Input.connect and Inputs.connect needs a big refactor.

@PProfizi PProfizi added the bug Something isn't working label Jan 7, 2025
@PProfizi PProfizi added this to the 0.13.4 milestone Jan 7, 2025
@PProfizi PProfizi requested a review from BClappe January 7, 2025 10:52
@PProfizi PProfizi self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (ff8e662) to head (d392596).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
- Coverage   88.44%   88.37%   -0.07%     
==========================================
  Files          89       89              
  Lines       10251    10251              
==========================================
- Hits         9066     9059       -7     
- Misses       1185     1192       +7     

@PProfizi PProfizi merged commit 7ba086b into master Jan 7, 2025
46 checks passed
@PProfizi PProfizi deleted the fix/any_connect_as_inpt branch January 7, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants