Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retro-compatibility for example 13-nodes_in_local_coordinate_system.py #1849

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 4, 2024

This fixes retro-compatibility of the example with DPF versions below 9.1 for the 0.13.1 release.

Passing CI for 251.pre0: https://github.com/ansys/pydpf-core/actions/runs/11666195430

@PProfizi PProfizi added the bug Something isn't working label Nov 4, 2024
@PProfizi PProfizi added this to the v0.13.1 milestone Nov 4, 2024
@PProfizi PProfizi self-assigned this Nov 4, 2024
@PProfizi PProfizi marked this pull request as ready for review November 4, 2024 14:18
@PProfizi PProfizi requested a review from BClappe November 4, 2024 14:18
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (c37f6a3) to head (df19c5a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.03%     
==========================================
  Files          83       83              
  Lines        9965     9951      -14     
==========================================
- Hits         8780     8765      -15     
- Misses       1185     1186       +1     

@PProfizi PProfizi merged commit 535c7b6 into master Nov 4, 2024
50 of 63 checks passed
@PProfizi PProfizi deleted the fix/example_retro_local_cs branch November 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants