Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a key argument to DataSources.set_domain_result_file_path() #1445

Merged

Conversation

PProfizi
Copy link
Contributor

No description provided.

@PProfizi PProfizi added the enhancement New feature or request label Feb 28, 2024
@PProfizi PProfizi self-assigned this Feb 28, 2024
Copy link
Contributor

@FedericoNegri FedericoNegri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out and it works well, thanks for the quick turnaround!

src/ansys/dpf/core/data_sources.py Outdated Show resolved Hide resolved
@PProfizi PProfizi requested a review from a team as a code owner February 28, 2024 17:41
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (924d709) to head (4e67c8b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          81       81           
  Lines        9550     9546    -4     
=======================================
- Hits         8389     8386    -3     
+ Misses       1161     1160    -1     

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (924d709) to head (321b92d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          81       81           
  Lines        9550     9546    -4     
=======================================
- Hits         8389     8386    -3     
+ Misses       1161     1160    -1     

@PProfizi PProfizi requested a review from rafacanton March 1, 2024 08:51
@PProfizi PProfizi enabled auto-merge (squash) March 1, 2024 09:04
@PProfizi PProfizi disabled auto-merge March 1, 2024 09:59
@PProfizi PProfizi merged commit 5a77146 into master Mar 1, 2024
39 checks passed
@PProfizi PProfizi deleted the feat/datasources_set_domain_result_file_path_with_key branch March 1, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants