Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ansys-fluent-visualization #38

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Adding ansys-fluent-visualization #38

merged 3 commits into from
Aug 10, 2022

Conversation

RobPasMue
Copy link
Member

Resolves #37

@RobPasMue RobPasMue self-assigned this Aug 4, 2022
@RobPasMue RobPasMue linked an issue Aug 4, 2022 that may be closed by this pull request
Including ansys-fluent-visualization as a dependency #37
Closed
@RobPasMue
Copy link
Member Author

This PR will not work until the issues with ansys-fluent-visualization are not solved. New version on their side will be required to loosen dependencies.

@RobPasMue RobPasMue mentioned this pull request Aug 4, 2022
Closed
@RobPasMue
Copy link
Member Author

I worked with the PyFluent team to get this new ansys-fluent-visualization release (0.4.1). With this release, all packages are working together :)

Pinging @akaszynski @MaxJPRey and @jorgepiloto for merging

jorgepiloto
jorgepiloto approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for implementing this, @RobPasMue 🚀

@RobPasMue RobPasMue merged commit fa43f8c into main Aug 10, 2022
@RobPasMue RobPasMue deleted the feat/add-ansys-fluent-visualization branch August 10, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@akaszynski akaszynski Awaiting requested review from akaszynski

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees

@RobPasMue RobPasMue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Including ansys-fluent-visualization as a dependency
2 participants
@RobPasMue @jorgepiloto