Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct artifact upload target directories for html and pdf documentation #536

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Dec 3, 2024

Expanding on the title, the directories being targeted by the action uploading the html and pdf documentation is incorrect. Corrected this (see the contents of tox.ini/Makefile).

…mentation

Expanding on the title, the directories being targeted by the action uploading the html and pdf documentation is incorrect. Corrected this (see the contents of tox.ini/Makefile).
@moe-ad moe-ad requested a review from jorgepiloto December 3, 2024 08:57
@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Dec 3, 2024
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @moe-ad!

@jorgepiloto jorgepiloto enabled auto-merge (squash) December 3, 2024 08:58
@moe-ad moe-ad requested a review from jorgepiloto December 3, 2024 10:34
@moe-ad moe-ad disabled auto-merge December 3, 2024 10:35
@moe-ad moe-ad enabled auto-merge (squash) December 3, 2024 10:36
@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 3, 2024

@jorgepiloto any idea why xvfb failed to start?

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @moe-ad

@moe-ad moe-ad mentioned this pull request Dec 12, 2024
@moe-ad moe-ad merged commit b318363 into main Dec 12, 2024
11 checks passed
@moe-ad moe-ad deleted the fix/mistake-in-nightly-build-action branch December 12, 2024 07:15
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
…mentation (#536)

Expanding on the title, the directories being targeted by the action uploading the html and pdf documentation is incorrect. Corrected this (see the contents of tox.ini/Makefile).
@RobPasMue
Copy link
Member

Looks like the headless display action fixed it

@moe-ad moe-ad self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants