Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Branch name protection fixes #531

Merged
merged 6 commits into from
Nov 20, 2024
Merged

fix: Branch name protection fixes #531

merged 6 commits into from
Nov 20, 2024

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Nov 20, 2024 •
edited
Loading

Fixes issues raised in #528 (comment)

@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Nov 20, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review November 20, 2024 08:43
RobPasMue
RobPasMue reviewed Nov 20, 2024
View reviewed changes
doc/source/_rulesets/branch_naming.json Outdated Show resolved Hide resolved
doc/source/_rulesets/branch_naming.json Outdated Show resolved Hide resolved
@AlejandroFernandezLuces @RobPasMue
Apply suggestions from code review
25d2620 
Co-authored-by: Roberto Pastor Muela <[email protected]>
RobPasMue
RobPasMue approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @greschd

greschd
greschd approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also like that the regex is now more understandable 🙂

@AlejandroFernandezLuces AlejandroFernandezLuces enabled auto-merge (squash) November 20, 2024 10:24
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 1722124 into main Nov 20, 2024
9 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/ruleset-issues branch November 20, 2024 10:27
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@AlejandroFernandezLuces @RobPasMue
fix: Branch name protection fixes (#531)
1c47626 
* fix: Branch name protection fixes

* Apply suggestions from code review

Co-authored-by: Roberto Pastor Muela <[email protected]>

* fix: Add suggested new names

* doc: Add new names to the contributing guide

* Update doc/source/_rulesets/branch_naming.json

Co-authored-by: Roberto Pastor Muela <[email protected]>

---------

Co-authored-by: Roberto Pastor Muela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@greschd greschd greschd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlejandroFernandezLuces @greschd @RobPasMue @MaxJPRey