Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: improve maxwell tests code cov #5746

Merged
merged 9 commits into from
Feb 8, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Feb 7, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.76%. Comparing base (01b93eb) to head (d859f2b).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (84.61%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5746      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files         157      157              
  Lines       61614    61634      +20     
==========================================
+ Hits        52230    52241      +11     
- Misses       9384     9393       +9     

@gmalinve gmalinve self-assigned this Feb 7, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 7, 2025 20:38
@gmalinve gmalinve linked an issue Feb 7, 2025 that may be closed by this pull request
@Samuelopez-ansys Samuelopez-ansys merged commit c800672 into main Feb 8, 2025
41 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the chore/improve_maxwell_cc branch February 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Maxwell tests and code coverage
2 participants