-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fix delete port #5713
FIX: Fix delete port #5713
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5713 +/- ##
==========================================
+ Coverage 85.21% 85.23% +0.01%
==========================================
Files 156 156
Lines 61217 61219 +2
==========================================
+ Hits 52169 52179 +10
+ Misses 9048 9040 -8 |
I have canceled the workflow, until the unit test is not implemented. |
Co-authored-by: Sébastien Morais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a typo in the documentation.
Yes, sorry fixed it now.
@amichel0205 I still do not see the unit test |
I would like to implement the test like this:
Doing this should check both option remove and not remove geometry, but will modify the state of self.aedtapp() at the end of the test where no port, neither via longer exist. |
Suggestions implemented
Description
To fix issue with function _delete port added an option to delete only port or port and geometry (same as option in AEDT UI)
Please provide a brief description of the changes made in this pull request.
Issue linked
close #5710
Checklist