Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removed support to SMRT.py #5707

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Jan 30, 2025

Removed elevation from import_from_openstreet_map method
Added note to documentation.

Description

SMRT.py could present some vulnerabilities due to the fact that the package is not updated since 2023.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

removed elevation from import_from_openstreet_map method
Added note to documentation.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 84.05797% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (2b15ad5) to head (2bc724f).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (84.05%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5707      +/-   ##
==========================================
+ Coverage   81.40%   85.15%   +3.75%     
==========================================
  Files         155      155              
  Lines       60833    60952     +119     
==========================================
+ Hits        49521    51906    +2385     
+ Misses      11312     9046    -2266     

SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 30, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft January 30, 2025 16:01
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review January 31, 2025 08:31
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 31, 2025 08:31
SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 31, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes !

src/ansys/aedt/core/modeler/advanced_cad/oms.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/advanced_cad/oms.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/advanced_cad/oms.py Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Morais <[email protected]>
@Samuelopez-ansys Samuelopez-ansys merged commit 174de93 into main Jan 31, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the remove_elevation_from_osm branch January 31, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants