Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Add Numpy issues #5705

Merged
merged 4 commits into from
Jan 30, 2025
Merged

DOCS: Add Numpy issues #5705

merged 4 commits into from
Jan 30, 2025

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jan 29, 2025

Description

Add a troubleshooting section for numpy issue.

Issue linked

Close #5675

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 29, 2025
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Jan 29, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data 1 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (f4b3c44) to head (3950c99).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5705      +/-   ##
==========================================
+ Coverage   81.38%   85.16%   +3.77%     
==========================================
  Files         155      155              
  Lines       60819    60819              
==========================================
+ Hits        49499    51797    +2298     
+ Misses      11320     9022    -2298     

MaxJPRey
MaxJPRey previously approved these changes Jan 30, 2025
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 30, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I rephrased a bit, let me know if you like the proposition or not :)

doc/source/Getting_started/Troubleshooting.rst Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 30, 2025 13:35
@Samuelopez-ansys Samuelopez-ansys merged commit f8986b1 into main Jan 30, 2025
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the doc/numpy_dotnetcore branch January 30, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Improve trouble shooting with dotnet
3 participants