New extension version manager #5702
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
For more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5702 +/- ##
==========================================
- Coverage 85.26% 83.39% -1.87%
==========================================
Files 155 156 +1
Lines 60794 61173 +379
==========================================
- Hits 51834 51015 -819
- Misses 8960 10158 +1198 |
…nto new-extension-version-manager
| :link-type: doc | ||
| :margin: 2 2 0 0 | ||
|
|
||
| Manager pyaedt and pyedb versions. |
There was a problem hiding this comment.
| Manager pyaedt and pyedb versions. | |
| Manage pyaedt and pyedb versions. |
|
|
||
| class VersionManager: | ||
| TITLE = "Version Manager {}".format(VERSION) | ||
| USER_GUIDE = "https://github.com/ansys-internal/pyaedt_version_manager" |
There was a problem hiding this comment.
This is an internal website. I think you could point to the pyaedt documentation (once it is built)
There was a problem hiding this comment.
Yes, please remove references to this org.
|
@hui-zhou-a This extension is great! But could you please use the same style than the others? I think you can see the choke designer one which has already multi tabs like this one and probably it will be easier for you to adapt. The icon of the app when it is opened, is not the PyAnsys logo, and to respect consistency with the other extension you should also import it. In summary, I think you could check the choke_designer toolkit and try to adapt the style |
For more information, see https://pre-commit.ci
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist