Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: plot formula #5560

Merged
merged 2 commits into from
Dec 12, 2024
Merged

FIX: plot formula #5560

merged 2 commits into from
Dec 12, 2024

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Dec 12, 2024

Reverted behaviour of get_report_plotter to plot real data when no formula is passed.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

#5559

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2024
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) December 12, 2024 08:44
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (7ba1650) to head (ee0c2cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5560   +/-   ##
=======================================
  Coverage   85.29%   85.30%           
=======================================
  Files         151      151           
  Lines       60753    60751    -2     
=======================================
  Hits        51822    51822           
+ Misses       8931     8929    -2     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 4f47c08 into main Dec 12, 2024
43 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_5559 branch December 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants