-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: PointCloud Generator for HFSS #5550
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5550 +/- ##
==========================================
- Coverage 84.74% 79.45% -5.30%
==========================================
Files 144 145 +1
Lines 60204 60772 +568
==========================================
- Hits 51021 48285 -2736
- Misses 9183 12487 +3304 |
@DomenicoLoricchio Good job! I am updating the extension UI, on this branch: I can apply it to your new extension once it is ready to be reviewed. |
Please do not miss to add tests and also the corresponding documentation :) |
@DomenicoLoricchio The "pip" key in the toml file is not for installing new dependencies. You should add it to the pyaedt dependencies, but we are trying to minimize the PyAEDT dependencies. Did you check if pyvista has a similar visualization mode? |
@Samuelopez-ansys open3d is not only used for the visualization but also for the generation of the cloud starting from the obj. Is it possible to use something like that: try: subprocess and sys are both modules of the standard python library. |
For more information, see https://pre-commit.ci
…_PointCloudGGenerator # Conflicts: # tests/system/solvers/test_45_workflows.py
For more information, see https://pre-commit.ci
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist