Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: PointCloud Generator for HFSS #5550

Closed
wants to merge 13 commits into from

Conversation

DomenicoLoricchio
Copy link

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@DomenicoLoricchio DomenicoLoricchio changed the title Added PointCloud Generator for HFSS FEAT: PointCloud Generator for HFSS Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 144 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (2b04f51) to head (cf9c0ec).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5550      +/-   ##
==========================================
- Coverage   84.74%   79.45%   -5.30%     
==========================================
  Files         144      145       +1     
  Lines       60204    60772     +568     
==========================================
- Hits        51021    48285    -2736     
- Misses       9183    12487    +3304     

@Samuelopez-ansys
Copy link
Member

@DomenicoLoricchio Good job!

I am updating the extension UI, on this branch:

#5549

I can apply it to your new extension once it is ready to be reviewed.

@Samuelopez-ansys
Copy link
Member

Please do not miss to add tests and also the corresponding documentation :)

@Samuelopez-ansys
Copy link
Member

@DomenicoLoricchio The "pip" key in the toml file is not for installing new dependencies.

You should add it to the pyaedt dependencies, but we are trying to minimize the PyAEDT dependencies.

Did you check if pyvista has a similar visualization mode?

@DomenicoLoricchio
Copy link
Author

@DomenicoLoricchio The "pip" key in the toml file is not for installing new dependencies.

You should add it to the pyaedt dependencies, but we are trying to minimize the PyAEDT dependencies.

Did you check if pyvista has a similar visualization mode?

@Samuelopez-ansys open3d is not only used for the visualization but also for the generation of the cloud starting from the obj.

Is it possible to use something like that:

try:
import open3d as o3d
except ModuleNotFoundError:
import subprocess
import sys
print("open3d is not installed. Installing it now...")
subprocess.check_call([sys.executable, "-m", "pip", "install", "open3d"])
print("open3d has been successfully installed!")
import open3d as o3d

subprocess and sys are both modules of the standard python library.
with this code only the users interested in this extension will install open3D

@DomenicoLoricchio DomenicoLoricchio marked this pull request as ready for review December 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants