Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default Roughness nodule radius #3875

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Samuelopez-ansys
Copy link
Member

Deprecate is_used_variable method
Reduce default Roughness nodule radius
Close #3360

Deprecate is_used_variable method
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #3875 (588ed75) into main (94e72ee) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3875   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         182      182           
  Lines       62747    62752    +5     
=======================================
+ Hits        50995    51001    +6     
+ Misses      11752    11751    -1     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys merged commit 55bbb97 into main Nov 14, 2023
11 of 12 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_3360 branch November 14, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve: Fix the default value of layer.bottom_nodule_radius in 3D Layout App
2 participants