maint: 2025 R1 update #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Andy-Grigg
commented
Oct 11, 2024
| @@ -120,7 +120,7 @@ | |||
| <dbKey xmlns="http://www.grantadesign.com/12/05/GrantaBaseTypes">MI_Restricted_Substances</dbKey> | |||
| <recordGUID xmlns="http://www.grantadesign.com/12/05/GrantaBaseTypes">92f90382-610a-4737-a18f-b153ea88e4ad</recordGUID> | |||
| </MIProcessReference> | |||
| <Identity>Primary processing, Metal extrusion, hot</Identity> | |||
| <Identity>Metal extrusion, hot</Identity> | |||
There was a problem hiding this comment.
This change isn't technically necessary. It was believed that the identity would override the name in the summary output, but the name in the database is always used instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 18 18
Lines 2542 2542
=======================================
Hits 2482 2482
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ludovicsteinbach
approved these changes
Oct 14, 2024
da1910
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests and database preparation scripts for 2025 R1 release.
Test fixes required by changes to data in 2025 R1 database.