Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pydocstyle in pyproject.toml file #478

Merged
merged 3 commits into from
May 21, 2024
Merged

fix: update pydocstyle in pyproject.toml file #478

merged 3 commits into from
May 21, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented May 17, 2024 •
edited
Loading

fix #476

@github-actions github-actions bot added the bug Something isn't working label May 17, 2024
MaxJPRey
MaxJPRey approved these changes May 18, 2024
View reviewed changes
Copy link

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys approved these changes May 18, 2024
View reviewed changes
Copy link

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Revathyvenugopal162 Revathyvenugopal162 enabled auto-merge (squash) May 21, 2024 07:10
@Revathyvenugopal162 Revathyvenugopal162 merged commit 483a5a9 into main May 21, 2024
45 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/add-code-style branch May 21, 2024 07:11
@MaxJPRey
Copy link

@Revathyvenugopal162 , @jorgepiloto, @SMoraisAnsys , @RobPasMue .
This is kind of best practices. I think we should remind it to our colleagues in the weekly meeting, because it would help us to improve the quality of the docstrings in the entire ecosystem.

@RobPasMue
Copy link
Member

Sure sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pydocstyle missing configuration for numpydoc convention
5 participants
@Revathyvenugopal162 @MaxJPRey @RobPasMue @SMoraisAnsys @pyansys-ci-bot