Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solutions token. #428

Closed
wants to merge 3 commits into from
Closed

Remove solutions token. #428

wants to merge 3 commits into from

Conversation

iazehaf
Copy link
Collaborator

@iazehaf iazehaf commented Jan 8, 2024

Remove solutions token. The setup_environment.py script is updated. This PR is a work-in-progress. Can be merge once a new release of solutions-common-files is available.

@iazehaf iazehaf added the enhancement New features or code improvements label Jan 8, 2024
@iazehaf iazehaf self-assigned this Jan 8, 2024
@nick-marnik
Copy link
Contributor

Curiously, we may need to check in with @jacobevansgit on his return - I think the update_environment.py update should be handled by propagate-bot after the change is merged to common-files.

I'm also curious if we should make the currently-failing solution template workflow required for PR merges:
image

@iazehaf iazehaf closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants