Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 734 - oSL template #410

Merged
merged 4 commits into from
Dec 8, 2023
Merged

fix bug 734 - oSL template #410

merged 4 commits into from
Dec 8, 2023

Conversation

ansRMorin
Copy link
Contributor

This PR fixes bug: https://github.com/Solution-Applications/solution-enablement-product-management/issues/734

  • it identifies data values that arent string, number, or bool type and converts it to a string
  • it also enables data to be copy and pasted from the datatable
  • it includes a scroll bar for data that overflows the cell width:

image

@ansRMorin ansRMorin requested a review from iazehaf December 7, 2023 23:44
@ansRMorin ansRMorin self-assigned this Dec 7, 2023
@ansRMorin ansRMorin requested a review from a team as a code owner December 7, 2023 23:44
@ansRMorin ansRMorin changed the title fix bug fix bug 734 - oSL template Dec 7, 2023
Copy link
Collaborator

@iazehaf iazehaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Working. Well done! One comment: the horizontal scroll in the design table is not persisted. Every time the UI gets refreshed, the scroll goes back to the initial state. I'll log an issue to fix this.

@ansRMorin ansRMorin merged commit 58284c4 into main Dec 8, 2023
54 checks passed
@ansRMorin ansRMorin deleted the rmorin/fix_bug734 branch December 8, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants