Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify font style and size #93

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 11, 2022

This PR is to add some of changes suggested by @timdansys as listed below:

  • improve the font size
  • Remove ansys-gold color from link hover
  • Remove the bottom border from breadcrumbs
  • Change color of switch button
  • Modify color of toctree
    new-1
    new-2

@github-actions github-actions bot added documentation enhancement General improvements to existing features labels Aug 11, 2022
@Revathyvenugopal162 Revathyvenugopal162 requested review from RobPasMue, PipKat, MaxJPRey, jorgepiloto and timdansys and removed request for RobPasMue August 11, 2022 10:58
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review August 11, 2022 10:59
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Aug 11, 2022
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am not experienced on the accessibility as the other reviewers. I'd leave them approve as well before merging

Comment on lines 3 to 4
/*@import url('https://fonts.googleapis.com/css2?family=Inconsolata:wght@600&display=swap');*/
@import url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:wght@300;400;600;700&display=swap');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/*@import url('https://fonts.googleapis.com/css2?family=Inconsolata:wght@600&display=swap');*/
@import url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:wght@300;400;600;700&display=swap');
@import url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:wght@300;400;600;700&display=swap');

If we are commenting statements, I'd just remove them... Not a fan of commented source code.

.gitignore Show resolved Hide resolved
@MaxJPRey
Copy link
Contributor

Thanks for adding the "underlying" when hovering over a main section at the top of the page.
image

@Revathyvenugopal162 Revathyvenugopal162 merged commit 6ca4aee into main Aug 11, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/modify-font-style-and-size branch August 11, 2022 13:21
@jorgepiloto jorgepiloto mentioned this pull request Aug 11, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants