Fix: search bar clear and individual index for docs #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Revathyvenugopal162
commented
May 25, 2023
•
Revathyvenugopal162
commented
- added the scroll bar
- highlight with color with all suggestions
- added the version index
- clear the search bar when the drop down index changes.
- Add more suggestions
github-actions
bot
added
documentation
bug
jorgepiloto
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Requesting some last changes. Style looks good! Thanks, @Revathyvenugopal162.
Co-authored-by: Jorge Martínez <[email protected]>
MaxJPRey
reviewed
Jul 19, 2023
Comment on lines
+51
to
+65
| // Listen for changes in the dropdown selector and update the index uid and suggestion accordingly | ||
| document | ||
| .getElementById("indexUidSelector") | ||
| .addEventListener("change", function () { | ||
| theSearchBar.indexUid = this.value; | ||
| theSearchBar.inputSelector = "#search-bar-input"; | ||
| theSearchBar.suggestionIndexUid = this.value; | ||
| theSearchBar.autocomplete.autocomplete.setVal(""); | ||
| }); | ||
|
|
||
| // Listen for changes in the search bar input and update the suggestion accordingly | ||
| document | ||
| .getElementById("search-bar-input") | ||
| .addEventListener("change", function () { | ||
| theSearchBar.suggestionIndexUid = | ||
| document.getElementById("indexUidSelector").value; |
There was a problem hiding this comment.
This should definitely help us to improve the suggestion provided to users.
There was a problem hiding this comment.
Thanks for handling that.
jorgepiloto
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.