Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: The search-bar-width #218

Merged
merged 14 commits into from
Feb 26, 2023
Merged

FIX: The search-bar-width #218

merged 14 commits into from
Feb 26, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Feb 23, 2023
@github-actions github-actions bot added the maintenance Generic maintenance related label Feb 24, 2023
@akaszynski
Copy link
Contributor

@Revathyvenugopal162, the only way I can get this to consistently work is to just fix the size of the search bar elements.

This is likely to be an adhoc fix that persists, but IMO it's sufficient for our work as we now no longer need to worry about the position of the dropdown.

Some of the content of the dropdown might be lost, but I think it's long enough to show most of the current content and the user can always click it to reveal the entire content.

@akaszynski akaszynski marked this pull request as ready for review February 26, 2023 03:25
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go if you're fine with my changes. Recommending a v0.9.4 release.

@Revathyvenugopal162 Revathyvenugopal162 merged commit d48a8dd into main Feb 26, 2023
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/search-bar branch February 26, 2023 09:38
jorgepiloto pushed a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants