Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : web accessibility. #202

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Fix : web accessibility. #202

merged 4 commits into from
Feb 21, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Feb 20, 2023 •
edited
Loading

Resolves #201 , resolves #203
codecell

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Feb 20, 2023
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review February 20, 2023 10:52
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Feb 20, 2023
MaxJPRey
MaxJPRey approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RobPasMue RobPasMue self-requested a review February 21, 2023 08:44
RobPasMue
RobPasMue approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now! LGTM :) Thanks @Revathyvenugopal162

@Revathyvenugopal162 Revathyvenugopal162 merged commit 3bf74ad into main Feb 21, 2023
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/web-accessibility branch February 21, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data table contrast is bright on dark theme. Class highlighting in dark mode is too bright.
3 participants
@Revathyvenugopal162 @RobPasMue @MaxJPRey