-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of extension libraries. #191
Conversation
I do not think we are allowed to use those images or distribute those, @Revathyvenugopal162. Also, you are executing the download of the examples during the CI/CD. That's smart but limits ourselves to only generate examples during the pipeline execution. In my opinion, we should use a similar logic to the one in [pyansys/actions], where by using [sphinx-jinja], we can inject any sort of content into an RST file. |
I was thinking of adding this code in conf file, also added this image to make sure it is working. I think We can do some modifications in the image.i will look in to using [sphinx-jinja]. But i am open to changes. |
…hinx-theme into feat/add-examples
…hinx-theme into feat/add-examples
Co-authored-by: Jorge Martínez <[email protected]>
Co-authored-by: Jorge Martínez <[email protected]>
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/static/js/table.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minior coments. What about the particle_background.jpg
file that is commited. Where is that image being used?
That is the background image for sphinx card. in examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome implementation, @Revathyvenugopal162. This is going to be really useful for our users. Approving. Feel free to merge 🚀
Thank you @jorgepiloto and @RobPasMue for the thorough review. merging! |
WIP