Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the styles for new version #187

Merged
merged 34 commits into from
Feb 1, 2023
Merged

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Jan 25, 2023

Fix #185

@github-actions github-actions bot added maintenance Generic maintenance related enhancement General improvements to existing features labels Jan 25, 2023
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review January 26, 2023 14:12
@Revathyvenugopal162
Copy link
Contributor Author

Live updates are at https://sphinxdocs.ansys.com/dev/index.html.

@RobPasMue
Copy link
Member

image

It's looking good but... is the scrollbar always going to appear even if it's unnecessary?

@Revathyvenugopal162
Copy link
Contributor Author

image

It's looking good but... is the scrollbar always going to appear even if it's unnecessary?

Oh yeah, i did it, once i implemented. i will change it now. Thanks for pointing it Robert.

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Jan 27, 2023

For the dark theme, could it be possible to increase the contrast for the release version?
image

The text could be darker.

@RobPasMue
Copy link
Member

For the dark theme, could it be possible to increase the contrast for the release version? image

The text could be darker.

Agreed yeah, we should increase the contrast

@Revathyvenugopal162
Copy link
Contributor Author

For the dark theme, could it be possible to increase the contrast for the release version? image

The text could be darker.

Done . https://sphinxdocs.ansys.com/dev/getting_started/index.html

@RobPasMue
Copy link
Member

Is it just my feeling or is the GH button waaaay too small?
image

@RobPasMue
Copy link
Member

RobPasMue commented Jan 27, 2023

Also:

image

This is a typical issue I face everywhere... would it be possible to get rid of that extra blank space formatted as a console statement, and add it to the right?

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Jan 27, 2023

Yes @RobPasMue, GitHub button should be bigger.

@@ -49,7 +49,7 @@ jobs:

doc-deploy-development:
name: Doc dev version deploy
if: github.event_name == 'push'
#if: github.event_name == 'push'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this comment so we do not forget about restoring this line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to do this @Revathyvenugopal162

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking much better now, thanks @Revathyvenugopal162

@Revathyvenugopal162
Copy link
Contributor Author

Thank you @MaxJPRey , @RobPasMue and @jorgepiloto for the suggestions and review, Merging and Will solve in another PR, if any modification required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the style for the new version.
4 participants