Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hint example function #137

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Add type hint example function #137

merged 5 commits into from
Oct 17, 2022

Conversation

GuillemBarroso
Copy link
Contributor

Adding function using type hinting to be used in dev-guide as example.

@github-actions github-actions bot added the enhancement General improvements to existing features label Oct 17, 2022
@RobPasMue RobPasMue self-requested a review October 17, 2022 13:00
MaxJPRey
MaxJPRey approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GuillemBarroso GuillemBarroso merged commit 3bb681b into main Oct 17, 2022
@GuillemBarroso GuillemBarroso deleted the feat/type-hint-example branch October 17, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
enhancement General improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillemBarroso @RobPasMue @MaxJPRey @Revathyvenugopal162