Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial mkdocs setup #234

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Initial mkdocs setup #234

merged 7 commits into from
Nov 9, 2023

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Oct 26, 2023 •
edited by ssbarnea
Loading

Fixes: #231

@shatakshiiii shatakshiiii added the enhancement This issue/PR relates to a feature request. label Oct 26, 2023
@shatakshiiii shatakshiiii self-assigned this Oct 26, 2023
@shatakshiiii shatakshiiii mentioned this pull request Nov 6, 2023
Merged
@shatakshiiii shatakshiiii marked this pull request as ready for review November 9, 2023 13:51
@shatakshiiii shatakshiiii requested a review from a team November 9, 2023 13:51
cidrblock
cidrblock approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome start... We can add more to the docs later

I noticed the requirements were switched to 3.10, was curious why...

@shatakshiiii
Copy link
Contributor Author

shatakshiiii commented Nov 9, 2023 •
edited
Loading

I noticed the requirements were switched to 3.10, was curious why...

No particular reason for this, first it came from local change then I saw that we have specified lowest python version in requirements.txt for most of our projects, that's why I was keeping this change.

@ssbarnea ssbarnea merged commit d31e55d into ansible:main Nov 9, 2023
9 checks passed
@shatakshiiii shatakshiiii deleted the mkdocs branch November 9, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyamsahoo priyamsahoo priyamsahoo approved these changes

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees

@shatakshiiii shatakshiiii

Labels
enhancement This issue/PR relates to a feature request.
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mkdocs based documentation building (RTD integrated)
4 participants
@shatakshiiii @cidrblock @priyamsahoo @ssbarnea