Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-add missing variables to passenv #106

Closed
ssbarnea opened this issue Sep 7, 2021 · 2 comments · Fixed by #107
Closed

Auto-add missing variables to passenv #106

ssbarnea opened this issue Sep 7, 2021 · 2 comments · Fixed by #107

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Sep 7, 2021

One very common mistake while using molecule with tox is to forget to alter passenv to add at least:

passenv =
  DOCKER_*
  CONTAINERS_*
  HOME
  SSH_AUTH_SOCK

Missing any of these can cause various failures which are no easy to debug by the average user. Adding them by default may make the plugin easier to use.

@greg-hellings
Copy link
Contributor

Currently we /should/ be passing through

passenv_list = (
    "HOME",
    "DOCKER_HOST",
    "CONTAINER_HOST",
)

Are these currently passing through? If not, then we need to write a test for that and fix it. If so, then we simply need to expand it. My use cases seem to indicate they are passing through properly, but I don't use any of those three things very heavily in my testing.

@ssbarnea
Copy link
Member Author

ssbarnea commented Sep 7, 2021

For sure SSH_AUTH_SOCK is needed, or you will be surprised to see failure from podman/docker on removes. That was my case, but i remembered about the other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants