Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous override of work unit status #942

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

TheRealHaoLiu
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu commented Feb 6, 2024

Certain failure condition that doesn't write stdinErr or stdoutErr result in the code erroneously overriden failed work unit status

This hides the real failure and cause us to end up with

"result_traceback": "Receptor detail:\nFinished",

instead of the real reason why the job failed (in this case k8s API server problem...)

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9f05dd2) 36.57% compared to head (ce1898c) 36.48%.
Report is 1 commits behind head on devel.

@@            Coverage Diff             @@
##            devel     #942      +/-   ##
==========================================
- Coverage   36.57%   36.48%   -0.09%     
==========================================
  Files          42       42              
  Lines        7878     7883       +5     
==========================================
- Hits         2881     2876       -5     
- Misses       4826     4837      +11     
+ Partials      171      170       -1     
Files Coverage Δ
pkg/workceptor/kubernetes.go 2.51% <0.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 7eaf7f2 into ansible:devel Feb 7, 2024
14 of 15 checks passed
@TheRealHaoLiu TheRealHaoLiu deleted the dont-ovveride-failure branch February 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants