Do not set stdoutErr at the end of EOF retry #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
stdoutErr is use to determine `errDetail` that's used in `kw.UpdateBasicStatus(WorkStateFailed, errDetail, stdout.Size())` in case where we retried 5 time and did not read any new log messages it is not an error it's the expected happy path so we should not set stdoutErr
TheRealHaoLiu
force-pushed
the
happy-eof
branch
from
52a8980 to
de7554e
Compare
|
Codecov ReportAttention:
@@ Coverage Diff @@
## devel #941 +/- ##
==========================================
- Coverage 36.57% 36.52% -0.05%
==========================================
Files 42 42
Lines 7878 7884 +6
==========================================
- Hits 2881 2880 -1
- Misses 4826 4835 +9
+ Partials 171 169 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdoutErris use to determineerrDetailthat's used inkw.UpdateBasicStatus(WorkStateFailed, errDetail, stdout.Size())in case where we retried 5 time and did not read any new log messages it is not an error it's the expected happy path so we should not set stdoutErr