Fix traceroute #233
Merged
Fix traceroute #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
approved these changes
Oct 13, 2020
…utine, and make use of it in packetconn
|
I added more stuff to this @fosterseth. Requesting re-review |
fosterseth
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #223. The problem was that at some previous stage, the
SubscribeUnreachablemechanism was switched from sendingUnreachableMessageto sendingmap[string]string, but this change was only partially completed. This didn't cause any errors because theBrokerclass takesinterface{}, so it passed these messages through just fine, but then they weren't processed on the receiving side.This PR adds type enforcement to the
Brokerclass, and adds a newUnreachableNotificationstruct, which includesUnreachableMessageand also the additional information of which node the message was received from.