-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding molecule template based on driver.name
#4126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In past when using cookicuter was possible to have templates based on a set of variables. This commit adds a default image entry when using 'containers', 'podman' or 'docker' drivers. The `init-scenario.yml` also will by default only copy the create.yml and destroy.yml if not using one of those container drivers.
mrbrandao
changed the title
Adding molecule template based on
Adding molecule template based on Feb 1, 2024
driver.name
driver.name
- issue #4128
mrbrandao
changed the title
Adding molecule template based on
Adding molecule template based on Feb 1, 2024
driver.name
- issue #4128driver.name
ssbarnea
approved these changes
Feb 7, 2024
ssbarnea
changed the title
Adding molecule template based on
Adding molecule template based on Feb 8, 2024
driver.name
driver.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In past when using
cookicuter
some molecule templates where straight forward to use delegated container drivers, such aspodman
anddocker
. Since it was gone, every time a new scenario is created it's needed to configure the templates again, by adding the image and the driver, also cleaning the files that will not be used by default such ascreate.yml
anddestroy.yml
If we can just init the scenario with a basic template that just works as we had in version
5
would be great.Here I'm bringing back some of this functionality, e.g:
This will create a
molecule.yml
as the following:it will also create the molecule scenario with just the
molecule.yml
and theconverge.yml
. e.g:If the scenario was any driver different than
podman
,docker
orcontainers
it will create the scenario with all the default templates from the currentdata
structure, e.g:The final scenario tree, after the commands
molecule init scenario -d podman podman
andmolecule init scenario
will look like:Fixes: #4128