Update The Filter For Red Hat Index of EE #1328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The category is called "Automation execution environment" as of this commit. Without this change the task completes without any issue but does not return any data.
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Can one of the admins verify this patch? |
newswangerd
added
backport-4.4
rochacbruno
requested changes
Jun 24, 2022
There was a problem hiding this comment.
- Commits must be signed
- add a
CHANGES/1737.bugfixwith one liner describing the change - We are requiring tests for every commit (however we do not have tests for execution environments yet so @newswangerd can give a hint on what/where to test)
I'm happy to waive the testing requirements for this PR. We don't have any tests for EE indexing as far as I know. |
|
@timway also need to add |
|
Reopening this here: #1346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
The category is called "Automation execution environment" as of this commit. Without this change the task completes without any issue but does not return any data.
Currently - Automation Execution Environment
vs
Modified - Automation execution environment
Issue: AAH-1737
Notes:
PR Author: Add a QE reviewer (exceptions);
Reviewers: look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit