Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locks on synclist tasks #1141

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

awcrosby
Copy link
Contributor

Description 🛠

Use shared_resources on calling parent task curate_all_synclist_repository
and calling child task curate_synclist_repository_batch. This prevents
golden_repo from being written to by another task.

Issue: AAH-1395

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

Use shared_resources on calling parent task `curate_all_synclist_repository`
and calling child task `curate_synclist_repository_batch`. This prevents
golden_repo from being written to by another task.

Issue: AAH-1395
Copy link

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Assuming all the curate synclist tasks do is read from the golden repo.

@awcrosby awcrosby merged commit 1c36735 into ansible:master Feb 23, 2022
@awcrosby awcrosby deleted the fix/improve_locks_on_curate_tasks branch February 23, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants