-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page endpoint for the console redhat #1130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brumik
requested review from
himdel and
newswangerd
and removed request for
himdel
February 14, 2022 10:58
rochacbruno
requested changes
Feb 14, 2022
newswangerd
requested changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python code looks pretty good overall. Added some comments about the data that's being returned as well as some improvements to the view code.
rochacbruno
approved these changes
Feb 15, 2022
newswangerd
reviewed
Feb 15, 2022
newswangerd
requested changes
Feb 23, 2022
newswangerd
reviewed
Feb 24, 2022
Issue: AAH-1278 This commit andds the endpoints for the landing page on the console.redhat.com. It is going to be a self service so all the dynamic data should be prefilled: collection and partner count in the current case.
/retest |
newswangerd
approved these changes
Feb 25, 2022
awcrosby
pushed a commit
that referenced
this pull request
Feb 28, 2022
* Add landing page endpoint for the console.redhat Issue: AAH-1278 This commit andds the endpoints for the landing page on the console.redhat.com. It is going to be a self service so all the dynamic data should be prefilled: collection and partner count in the current case. * Add integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-1278
This commit adds the endpoints for the landing page on the console.redhat.com. It is going to be a self service so all
the dynamic data should be prefilled: collection and partner in the current case.
Next after this is deployed to STAGE by this document
The currently used schema is here: https://github.com/RedHatInsights/landing-page-frontend/blob/b1f358352916f3f6b4813e9cfe0b4a7765005109/src/contentApi/ansible-api.js#L500
The expected prefilled format example: https://github.com/RedHatInsights/landing-page-frontend/blob/master/docs/exmple-schema.md