Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable streamed sync endpoints #1012

Merged

Conversation

awcrosby
Copy link
Contributor

@awcrosby awcrosby commented Oct 7, 2021

This PR temporarily disables the streamed sync endpoints (basically reverting #806) to support a timed and planned rollout of client and server functionality.

Related-Issue: AAH-224

@awcrosby
Copy link
Contributor Author

awcrosby commented Oct 7, 2021

@rochacbruno @ironfroggy I am raising this PR to master and after merge I will cherry-pick to stable for cloud deployments. Should this be backported to stable-4.4 branch for when on-prem is used as the server so this is disabled everywhere until we are ready to turn it on?

@rochacbruno
Copy link
Member

@awcrosby awcrosby force-pushed the fix/disable_streamed_sync_endpoints branch 2 times, most recently from 45efd37 to 65e37b9 Compare October 7, 2021 16:10
Related-Issue: AAH-224
@awcrosby awcrosby force-pushed the fix/disable_streamed_sync_endpoints branch from 65e37b9 to d6dc562 Compare October 7, 2021 16:37
@awcrosby awcrosby added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 7, 2021
@awcrosby awcrosby merged commit ce51f37 into ansible:master Oct 7, 2021
@patchback
Copy link

patchback bot commented Oct 7, 2021

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/ce51f37dac5af3f3ccb03dcb4f97f623f8b4fb39/pr-1012

Backported as #1013

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@awcrosby awcrosby deleted the fix/disable_streamed_sync_endpoints branch October 7, 2021 18:15
patchback bot pushed a commit that referenced this pull request Oct 7, 2021
Related-Issue: AAH-224
(cherry picked from commit ce51f37)
awcrosby added a commit to awcrosby/galaxy_ng that referenced this pull request Oct 7, 2021
awcrosby added a commit that referenced this pull request Oct 7, 2021
Related-Issue: AAH-224
(cherry picked from commit ce51f37)

Co-authored-by: Andrew Crosby <[email protected]>
awcrosby added a commit that referenced this pull request Oct 7, 2021
@himdel himdel added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants