-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement extra_settings_files #125
base: main
Are you sure you want to change the base?
Conversation
@rooftopcellist @Denney-tech |
@rooftopcellist @Denney-tech |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I don't know if I can "approve" but I will try.
Edit: Apparently "Approving" in a review is not the same as approving a workflow lol. TIL
Updated, ready for review again😃 |
o/ @kurokobo @Denney-tech Thank you for the PR and for testing it. This is a great addition! Sorry for the delay here, it has been a busy couple weeks.. I have this on my list to review. CI has been triggered. |
LGTM |
Quality Gate passedIssues Measures |
Any chance we can see this get merged soon? Not sure if it's too stale to merge as-is, but I am disappointed it's been sitting here so long. |
SUMMARY
This PR implements
extra_settings_files
, which is almost the same as my PR for AWX Operator ansible/awx-operator#1836Required module (
split_settings
) to load additional*.py
files is already installed in galaxy images: https://github.com/ansible/galaxy_ng/blob/c52e9b4e5548ca38946d7cc1bd8624459def1ec1/requirements/requirements.common.txt#L127-L128Design:
*.py
files from ConfigMaps or Secrets*.py
files under/etc/pulp/conf.d
in following pods which already havesettngs.py
Restrictions:
Completely the same as described in ansible/awx-operator#1836
ADDITIONAL INFORMATION
Tested with and without
extra_settings_files
:Without
extra_settings_files
Ensure there is no
/etc/pulp/conf.d
$ kubectl -n galaxy exec -it deployment/galaxy-api -- ls -l /etc/pulp total 4 drwxrwxr-x. 2 galaxy root 6 May 1 13:01 certs drwxrwxr-x. 1 galaxy root 118 May 24 12:53 keys -rw-r--r--. 1 root root 1531 May 24 12:52 settings.py
Even if there is no actual directory and files,
include()
does not cause error sinceoptional()
is used to load files.With
extra_settings_files
Result:
I can confirm that additional settings in
*.py
take effects, e.g. browsing existing collections without logging in to the Galaxy byGALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_ACCESS = True
.