Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE Getting started: add SSH forwarding #39

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

Andersson007
Copy link
Contributor

EE Getting started: add SSH forwarding

@Andersson007
Copy link
Contributor Author

ready for review

@Andersson007 Andersson007 requested a review from oraNod April 16, 2024 10:53
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits. Thanks @Andersson007

docs/getting_started_ee/run_execution_environment.md Outdated Show resolved Hide resolved
docs/getting_started_ee/run_execution_environment.md Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor Author

@oraNod committed, thanks, PTAL

@Andersson007
Copy link
Contributor Author

if no other suggestions, feel free to merge, another person confirmed that it works

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andersson007 Sorry to badger you with more nits but just a couple things to refine. LGTM overall though. Thanks!

docs/getting_started_ee/run_execution_environment.md Outdated Show resolved Hide resolved
docs/getting_started_ee/run_execution_environment.md Outdated Show resolved Hide resolved
docs/getting_started_ee/run_execution_environment.md Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor Author

@Andersson007 Sorry to badger you with more nits but just a couple things to refine. LGTM overall though. Thanks!

@oraNod we make as many improvements and iterations as needed, all committed, looks much better now, thanks!
PTAL

@oraNod oraNod merged commit bcf3077 into ansible:main Apr 23, 2024
2 checks passed
@oraNod
Copy link
Contributor

oraNod commented Apr 23, 2024

thanks @Andersson007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants