Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nox session to pip-compile requirements #229

Merged
merged 24 commits into from
Mar 7, 2024
Merged

Add nox session to pip-compile requirements #229

merged 24 commits into from
Mar 7, 2024

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Feb 28, 2024

No description provided.

@oraNod oraNod requested a review from webknjaz February 28, 2024 14:13
@oraNod oraNod mentioned this pull request Feb 28, 2024
Merged
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@oraNod oraNod force-pushed the pipcompile-nox-session branch from da352c2 to f5e8ead Compare February 28, 2024 19:27
@oraNod
Copy link
Collaborator Author

oraNod commented Feb 28, 2024

@gotmax23 I can't seem to be able to add you as a reviewer here but I would appreciate if you could please take a look. I've borrowed from your noxfile in the ansible-documentation repo. You might have some nits or comments. I'd also like to add you as a co-author but wanted to give a heads up first. Cheers.

@oraNod oraNod requested a review from webknjaz February 28, 2024 19:49
webknjaz
webknjaz reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
pip-tools.in Outdated Show resolved Hide resolved
@gotmax23
Copy link
Contributor

@gotmax23 I can't seem to be able to add you as a reviewer here but I would appreciate if you could please take a look. I've borrowed from your noxfile in the ansible-documentation repo. You might have some nits or comments. I'd also like to add you as a co-author but wanted to give a heads up first. Cheers.

I'll try to take a closer look later. Thanks for the heads up and thanks, @webknjaz, for taking a look as well.

gotmax23
gotmax23 reviewed Feb 28, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
gotmax23
gotmax23 reviewed Feb 28, 2024
View reviewed changes
noxfile.py Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 1, 2024
View reviewed changes
requirements/pip-tools.in Outdated Show resolved Hide resolved
@oraNod oraNod force-pushed the pipcompile-nox-session branch from 0e76c90 to 8deb2b7 Compare March 4, 2024 13:25
webknjaz
webknjaz reviewed Mar 4, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Mar 4, 2024
View reviewed changes
noxfile.py Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 4, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Mar 5, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
oraNod and others added 9 commits March 6, 2024 16:34
@oraNod
use toml file for pip tools config
a3c2918
@oraNod @webknjaz
add pip compile session
ab34ed1 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@oraNod
parametrize requirements files
9595046
@oraNod
add pip-tools lock file
fc6debd
@oraNod
add pip-tools session requirements
185ed95
@oraNod
add docstrings to nox sessions
35909c9
@oraNod
formatting nit
1c1dcf8
@oraNod @webknjaz
Update noxfile.py
728602b 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@oraNod @webknjaz
Update pip-tools.in
0f7fbeb 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@oraNod oraNod force-pushed the pipcompile-nox-session branch from 32c8eea to 40e9555 Compare March 6, 2024 16:45
gotmax23
gotmax23 reviewed Mar 6, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 6, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 6, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 6, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
gotmax23
gotmax23 reviewed Mar 6, 2024
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
oraNod and others added 4 commits March 7, 2024 08:43
@oraNod oraNod merged commit d0b1ab7 into ansible:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oraNod @gotmax23 @webknjaz