Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific titles for each page #202

Merged
merged 1 commit into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/404.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = "Not found" %}
{% extends "_base.html" %} {% block body %}
<section class="container">
<div class="row-fluid-wrapper row-depth-1 row-number-3">
Expand Down
2 changes: 1 addition & 1 deletion templates/_base.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>{{ base.site_title }}</title>
<title>{{ (page_title ~ " | " if page_title is defined else "") ~ base.site_title }}</title>
<meta name="description" content="{{ base.site_description }}" />
<meta name="author" content="{{ base.site_author }}" />
<link rel="stylesheet"
Expand Down
1 change: 1 addition & 0 deletions templates/ansible-prior-versions.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.community.archive.title %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do this in a follow up but this one is probably too long:

title: Join the Ansible community

I've been thinking about how we could improve it so it is more consistent with the other personas. It looks like an outlier in the navigation. Any thoughts?

{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/ansible_community.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.community_docs.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/automation-tower-chinese-translations.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.controller.tower_zh.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/automation-tower-japanese-translations.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.controller.tower_ja.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/automation-tower-korean-translations.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.controller.tower_ko.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/automation-tower-prior-versions.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.controller.archive.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/community.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.community.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/core-translated-ja.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.core.core_ja.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/core.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.core.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/developers.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.developers.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/ecosystem.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.ecosystem.title %}
{% extends "_base.html" %}
{% block body %}
<div class="container">
Expand Down
1 change: 1 addition & 0 deletions templates/maintainers.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.maintainers.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/platform.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.platform.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down
1 change: 1 addition & 0 deletions templates/users.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set page_title = pages.users.title %}
{% extends "_base.html" %} {% block body %}
<div class="container">
<div class="full-width-bg component">
Expand Down